[Tile-serving] [openstreetmap/osm2pgsql] second attempt at file clean-up (#771)

[Sarah Hoffmann]

lonvia commented on this pull request.

The style/wording changes look okay to me. The wiki links though, I find rather distracting. They make it hard to see what is comment and what is content. (But then again, I know those tags inside out, so this might be expert bias.)

>  #
-# With --hstore-all all tags are added to the hstore column unless they appear
-# in the style file with a delete flag, causing duplication between the normal
-# columns and the hstore column.
+# With --hstore-all,  all tags are added to the hstore column unless they

one space two many

> +# Wiki pages
+# ==========
+#
+# In general, the OpenStreetMap wiki contains a page named for each tag or
+# tag set.  For example:
+#
+#   access          http://wiki.openstreetmap.org/wiki/Key:access
+#   addr:housename  http://wiki.openstreetmap.org/wiki/Key:addr
+#   note:*          http://wiki.openstreetmap.org/wiki/Key:note
+#   tower:type      http://wiki.openstreetmap.org/wiki/Key:tower:type
+#
+# A few tags (e.g., abandoned, disused) are treated as lifecycle prefixes.
+# Their wiki pages contain a terminating colon (:).  For example:
+#
+#   abandoned       http://wiki.openstreetmap.org/wiki/Key:abandoned:
+#   disused         http://wiki.openstreetmap.org/wiki/Key:disused:

I'm not convinced that the style file is the right place to explain the OSM tagging system. A one liner like "For an see the OSM wiki at https://wiki.openstreetmap.org." should be sufficient and would be less distracting.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/771#pullrequestreview-52476441
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20170726/fbcfa5d2/attachment-0001.html>