[Tile-serving] [openstreetmap/osm2pgsql] multi-output: reintroduce line spliting (#755)

[Paul Norman]

pnorman commented on this pull request.

I haven't done any testing yet, but otherwise the code looks okay.

>  {
     wkbs_t ret;
 
-    double const split_at = m_proj->target_latlon() ? 1 : 100 * 1000;
+    bool do_split = split_at > 0.0;

Are we setting the stage for any floating point comparison issues later on?

> @@ -18,6 +18,5 @@ geometry_processor::wkbs_t
 processor_line::process_relation(osmium::Relation const &,
                                  osmium::memory::Buffer const &ways)
 {
-    // XXX are multilines really acceptable?
-    return m_builder.get_wkb_multiline(ways, false);
+    return m_builder.get_wkb_multiline(ways, 1000000);

Given the size of North American road relations and the Mercator scaling, it's safer to use 10 000 000.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/755#pullrequestreview-36721086
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20170508/5c83a09f/attachment.html>