[Tile-serving] [openstreetmap/osm2pgsql] Make some functions return void instead of int (#1021)

[Jochen Topf]

joto commented on this pull request.



> @@ -198,10 +196,9 @@ int output_pgsql_t::pending_relation(osmid_t id, int exists)
         }
 
         auto const &rel = rels_buffer.get<osmium::Relation>(0);
-        return pgsql_process_relation(rel);
+        pgsql_process_relation(rel);
+        return;

The new way makes clear that `pgsql_process_relation` doesn't return anything. If we ever change the function this is in to return something again, this new code will break regardless of whether `pgsql_process_relation` returns something or not, helping us to detect that there is a place here that needs looking at.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1021#discussion_r355193388
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20191208/b2992a0f/attachment.html>