[Tile-serving] [openstreetmap/osm2pgsql] Refactor tests pg code (#1025)

Jochen Topf notifications at github.com
Tue Dec 10 15:42:05 UTC 2019


Refactor low-level PostgreSQL code in the tests to use the low-level PostgreSQL code used in the application. This gives us simpler and better tested code and we can use convenience functions originally only implemented in the test code.

This also marks the tempdb_t constructor noexcept.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/osm2pgsql/pull/1025

-- Commit Summary --

  * Mark tempdb_t constructor as noexcept and add missing special functions
  * Make pg_result_t into a real type and add convenience functions
  * Make conn_t class in tests derive from pg_conn_t
  * Use recently added pg_result_t::num_tuples() helper

-- File Changes --

    M src/middle-pgsql.cpp (34)
    M src/pgsql.hpp (30)
    M tests/common-pg.hpp (94)

-- Patch Links --

https://github.com/openstreetmap/osm2pgsql/pull/1025.patch
https://github.com/openstreetmap/osm2pgsql/pull/1025.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1025
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20191210/bcc9d05b/attachment.html>


More information about the Tile-serving mailing list