[Tile-serving] [openstreetmap/osm2pgsql] Add support for --extra-attributes to Gazetteer output (#905)

[Sarah Hoffmann]

lonvia commented on this pull request.

Looks mostly good now. I particularly like the reused osmium type for metadata. Could you please also add a check that only the EXTRA flag is set. Nothing else really makes sense with the meta data. 

> @@ -163,6 +163,25 @@ gazetteer_style_t::flag_t gazetteer_style_t::parse_flags(std::string const &str)
     return out;
 }
 
+bool gazetteer_style_t::add_metadata_style_entry(std::string const &key,
+                                                 std::string const &value)

'value' is unused here. You can just remove the second parameter. (I wonder why travis does not complain, we need to change that.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/905#pullrequestreview-201867035
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20190209/b14d1e84/attachment.html>