[Tile-serving] [openstreetmap/osm2pgsql] Fix various unused parameter issues and enable -Wextra on travis (#906)

[Sarah Hoffmann]

This fixes all -Wextra warnings. Mostly removes unused parameters and a couple of useless asserts. It also removes the randomized parameter test because it contained some bad parameter usage and it was impossible to figure out what the actual intention of the test was.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/osm2pgsql/pull/906

-- Commit Summary --

  * fix warnings appearing with -Wextra
  * enable -Wextra for travis builds
  * remove ineffective assertions

-- File Changes --

    M .travis.yml (10)
    M middle-ram.cpp (2)
    M output-multi.cpp (6)
    M output-multi.hpp (2)
    M output-pgsql.cpp (7)
    M output-pgsql.hpp (2)
    M tagtransform-c.cpp (7)
    M tests/test-expire-tiles.cpp (2)
    M tests/test-hstore-match-only.cpp (2)
    M tests/test-middle-flat.cpp (91)
    M tests/test-middle-pgsql.cpp (89)
    M tests/test-middle-ram.cpp (26)
    M tests/test-options-database.cpp (2)
    M tests/test-options-parse.cpp (151)
    M tests/test-output-multi-line-storage.cpp (2)
    M tests/test-output-multi-line.cpp (2)
    M tests/test-output-multi-point-multi-table.cpp (2)
    M tests/test-output-multi-point.cpp (2)
    M tests/test-output-multi-poly-trivial.cpp (2)
    M tests/test-output-multi-polygon.cpp (2)
    M tests/test-output-multi-tags.cpp (2)
    M tests/test-output-pgsql-area.cpp (2)
    M tests/test-output-pgsql-schema.cpp (2)
    M tests/test-output-pgsql-tablespace.cpp (2)
    M tests/test-output-pgsql-validgeom.cpp (2)
    M tests/test-output-pgsql-z_order.cpp (2)
    M tests/test-output-pgsql.cpp (2)
    M tests/test-parse-diff.cpp (11)
    M tests/test-parse-extra-args.cpp (4)
    M tests/test-parse-xml2.cpp (37)
    M tests/test-pgsql-escape.cpp (2)

-- Patch Links --

https://github.com/openstreetmap/osm2pgsql/pull/906.patch
https://github.com/openstreetmap/osm2pgsql/pull/906.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/906
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20190209/5bbdabad/attachment.html>