[Tile-serving] [openstreetmap/osm2pgsql] Reorganzise regression tests (#1003)
Sarah Hoffmann
notifications at github.com
Mon Nov 25 19:39:21 UTC 2019
This is a complete rewrite of the regression tests making more use of the boilerplating provided by Python unittest. In addition cmake now installs a Python script in the build directory that allows to execute the tests from any directory.
There is a couple of goals here:
* Make sure all checks are always executed, even when some of them fail. This was always a major source of pain when updating the values after osm2pgsql's behaviour has changed.
* Make it more obvious how the checks go together. You can now see how the different parameters change the outcome of the different SQL queries. (In fact, some of those are worth looking at.)
* Make it easier to add/remove tests for a group of different osm2pgsql runs.
I've left almost all of the tests as they were before. However, looking at the multipolygon tests, many of them have been created for old-style MPs and are not that useful anymore.
Fixes #490.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/osm2pgsql/pull/1003
-- Commit Summary --
* Reorganzise regression tests
-- File Changes --
M tests/CMakeLists.txt (6)
D tests/regression-test.py (628)
A tests/regression-test.py.tmpl (15)
D tests/regression-test.sh (4)
A tests/regression.py (737)
-- Patch Links --
https://github.com/openstreetmap/osm2pgsql/pull/1003.patch
https://github.com/openstreetmap/osm2pgsql/pull/1003.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1003
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20191125/7f3baac9/attachment.html>
More information about the Tile-serving
mailing list