[Tile-serving] [openstreetmap/osm2pgsql] Use fmt library instead of boost::format (#1004)

[Jochen Topf]

joto commented on this pull request.



>              }
             for (size_t i = 0; i < hstore_columns.size(); ++i) {
-                m_sql_conn->exec("CREATE INDEX ON %1% USING GIN (\"%3%\") %4%",
-                                 m_target->name, i, hstore_columns[i],
-                                 (table_space_index
-                                      ? "TABLESPACE " + table_space_index.get()
-                                      : ""));
+                m_sql_conn->exec(
+                    "CREATE INDEX ON {} USING GIN (\"{}\") {}"_format(
+                        m_target->name, i, hstore_columns[i],

It seems this is expected behaviour for fmt. too many parameters isn't considered an error. i have fixed this and did a force push.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1004#discussion_r352142967
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20191129/e228f592/attachment.html>