[Tile-serving] [openstreetmap/osm2pgsql] avoid ways/rels update for non moving node updates (#1059)

mmd notifications at github.com
Sat Feb 15 10:45:42 UTC 2020


mmd-osm commented on this pull request.



> @@ -38,6 +38,11 @@ void middle_ram_t::nodes_set(osmium::Node const &node)
     cache->set(node.id(), node.location());
 }
 
+osmium::Location middle_ram_t::nodes_get(osmid_t osm_id)
+{
+    return cache->get(osm_id);
+}
+

There are there are also other locations where nodes_get would have to be implemented, see compiler errors:

```
In file included from /home/travis/build/openstreetmap/osm2pgsql/tests/test-parse-extra-args.cpp:15:

/home/travis/build/openstreetmap/osm2pgsql/tests/mockups.hpp:7:8: note:   because the following virtual functions are pure within ‘dummy_middle_t’:

 struct dummy_middle_t : public middle_t {

        ^~~~~~~~~~~~~~

In file included from /home/travis/build/openstreetmap/osm2pgsql/tests/test-parse-extra-args.cpp:9:

/home/travis/build/openstreetmap/osm2pgsql/middle.hpp:91:30: note: 	‘virtual osmium::Location middle_t::nodes_get(osmid_t)’

     virtual osmium::Location nodes_get(osmid_t osm_id) = 0;
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1059#pullrequestreview-359339344
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20200215/a9836b1b/attachment.htm>


More information about the Tile-serving mailing list