[Tile-serving] [openstreetmap/osm2pgsql] Don't use ST_GeoHash for ordering on Postgis >= 2.4 (#1050)

[Jochen Topf]

joto commented on this pull request.



> @@ -186,30 +186,45 @@ void table_t::stop(bool updateable, bool enable_hstore_index,
         fprintf(stderr, "Sorting data and creating indexes for %s\n",
                 m_target->name.c_str());
 
-        if (srid == "4326") {
-            /* libosmium assures validity of geometries in 4326, so the WHERE can be skipped.
-               Because we know the geom is already in 4326, no reprojection is needed for GeoHashing */
-            m_sql_conn->exec(
-                "CREATE TABLE {0}_tmp {1} AS\n"
-                "  SELECT * FROM {0}\n"
-                "    ORDER BY ST_GeoHash(way,10)\n"
-                "    COLLATE \"C\""_format(m_target->name, m_table_space));
+        // Notices about invlaid geometries are expected and can be ignored

typo "invlaid"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1050#pullrequestreview-338402346
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20200105/f11bfa73/attachment.htm>