[Tile-serving] [openstreetmap/osm2pgsql] Remove superfluous checks for append mode. (#1051)

[Jochen Topf]

Inside the pgsql output (and only in that output) we checked whether we
are in append mode in (the node|way|relation)_(modify|delete) functions.
This is not needed because oms2pgsql checks early on that option -a
isn't used without -s.

This can also be seen because at the callsite of those functions we are
doing an unchecked dynamic_cast that would have failed and returned a
nullptr if we are not in slim mode. So we would have never reached those
checkes. I have added assert()s to make clear we are relying on those
dynamic_casts to work.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/osm2pgsql/pull/1051

-- Commit Summary --

  * Remove superfluous checks for append mode.

-- File Changes --

    M src/osmdata.cpp (6)
    M src/output-pgsql.cpp (25)

-- Patch Links --

https://github.com/openstreetmap/osm2pgsql/pull/1051.patch
https://github.com/openstreetmap/osm2pgsql/pull/1051.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1051
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20200107/1f08b31d/attachment.htm>