[Tile-serving] [openstreetmap/osm2pgsql] Extended schema support to pgsql backend. (#1241)

[Jochen Topf]

@joto commented on this pull request.

* Maybe use `public` as default, that would remove some `empty()` checks?
* New `--schema` option is not documented (should be at least in doc/osm2pgsql.1). It should also be documented in `doc/flex.md`, that the flex backend doesn't use this option.
* Adding more command line options is going in the wrong direction I believe. I'd rather see some kind of config file.
* This forces the schema to be the same in the pgsql output and the middle. There is some precedence with the `--tablespace*` options to allow these to be different. Also it doesn't work on the gazeteer backend and multi-backend (which is deprecated anyway, so that's fine).
* No tests (see also `tests/test-output-pgsql-schema.cpp`).

I think we should have a general idea where we are going with the configuration and how we want to handle the options for the different outputs and the middle in a systematic way before adding more options.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1241#pullrequestreview-442294780
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20200703/84378d80/attachment.htm>