[Tile-serving] [openstreetmap/osm2pgsql] Extended schema support to pgsql backend. (#1241)

[Sarah Hoffmann]

Not so quick. While I value @joto's opinions, he is not the one with the power over the merge button around here. ;)

It is true that we need to reconsider the approach to configuration options. But that is not going to happen today or next week and we need to be practical here. This is a feature that has been requested quite often and I'm on record stating that I take a pull request that implements this as an extra option. This is still true. On a quick look into it, this PR meets the requirements.

So I'll reopen the PR in the hope that we might get it in before the next release (which is rather imminent). I still need to do a detailed review later. For the moment, two of the points that @joto mentions, I'd definitely liked to see addressed, too: the documentation needs to be adapted and we should have at least one test. The test could consist of an additional regression test or do as @joto says. @zerebubuth I'd really appreciate if you can look into this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1241#issuecomment-653539199
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20200703/d9e1f4fc/attachment.htm>