[Tile-serving] [openstreetmap/osm2pgsql] Make clustering of tables by geometry optional (#1227)

[Sarah Hoffmann]

@lonvia commented on this pull request.



> -                "  IF ST_IsValid(NEW.{}) THEN \n"
-                "    RETURN NEW;\n"
-                "  END IF;\n"
-                "  RETURN NULL;\n"
-                "END;"
-                "$$ LANGUAGE plpgsql;"_format(table().name(),
-                                              table().geom_column().name()));
-
-            m_db_connection->exec("CREATE TRIGGER \"{0}_osm2pgsql_valid\""
-                                  " BEFORE INSERT OR UPDATE"
-                                  " ON {1}"
-                                  " FOR EACH ROW EXECUTE PROCEDURE"
-                                  " {0}_osm2pgsql_valid();"_format(
-                                      table().name(), table().full_name()));
-        }
+        create_trigger_for_geom_check();

Are you sure that isn't called twice when clustering is disabled?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1227#pullrequestreview-436157309
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20200623/e1a0e153/attachment.htm>