[Tile-serving] [openstreetmap/osm2pgsql] Fix: Results of tasks run in thread pool were not checked (#1229)

Jochen Topf notifications at github.com
Wed Jun 24 16:27:24 UTC 2020


If a function run in the thread pool throws an exception, this exception
was never "collected", it was silently ignored. This commit fixes this
by wrapping the osmium::thread::Pool class in a class of our own that
keeps track of the futures returned by submit() and allows checking
them.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/osm2pgsql/pull/1229

-- Commit Summary --

  * Fix: Results of tasks run in thread pool were not checked

-- File Changes --

    M src/CMakeLists.txt (1)
    M src/middle-pgsql.cpp (2)
    M src/middle-pgsql.hpp (2)
    M src/middle-ram.cpp (2)
    M src/middle-ram.hpp (2)
    M src/middle.hpp (5)
    M src/osmdata.cpp (10)
    M src/output-flex.cpp (2)
    M src/output-flex.hpp (2)
    M src/output-gazetteer.hpp (2)
    M src/output-multi.cpp (2)
    M src/output-multi.hpp (2)
    M src/output-null.hpp (2)
    M src/output-pgsql.cpp (2)
    M src/output-pgsql.hpp (2)
    M src/output.hpp (5)
    A src/thread-pool.hpp (50)
    M tests/test-parse-osmium.cpp (2)

-- Patch Links --

https://github.com/openstreetmap/osm2pgsql/pull/1229.patch
https://github.com/openstreetmap/osm2pgsql/pull/1229.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1229
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20200624/1c5db68a/attachment.htm>


More information about the Tile-serving mailing list