[Tile-serving] [openstreetmap/osm2pgsql] In-band metadata in middle layer (#1170)

[mmd]

Let's assume I've created some Overpass extract which doesn't include metadata (i.e. `out;` instead of `out meta;` ). With GDPR in mind, this could also mean that some metadata fields like user, uid and changeset may be missing in the future.

Now, when processing such a file via osm2pgsql with extra attributes enabled, a mapper (!) can control the metadata fields due to the logic in taglist_t::add_attributes. This way, random values can be written to the metadata fields. Even worse, setting some special purpose keys to invalid values can abort osm2pgsql altogether.

Example test data:

```
<?xml version="1.0" encoding="UTF-8"?>
<osm version="0.6" generator="Overpass API 0.7.56.3 eb200aeb">
 <node id="25477618" lat="49.1837670" lon="-122.9572343">
  <tag k="highway" v="traffic_signals"/>
  <tag k="osm_uid" v="x"/>
 </node>
</osm>
```

Result: Osm2pgsql failed due to ERROR: illegal user id: 'x'

./osm2pgsql ---create --slim  -O flex -S ../flex-config/simple.lua demo.osm -x

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/issues/1170
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20200517/97e809b2/attachment.htm>