[Tile-serving] [openstreetmap/osm2pgsql] Add --middle-propagate-changes option (#1310)

Jochen Topf notifications at github.com
Thu Nov 5 16:53:32 UTC 2020


Add new command line option --middle-propagate-changes. Set this to
"false" to suppress the normal propagation of changes in append mode
from nodes to ways to relations. This is intended mainly for Nominatim
which doesn't need this propagation.

I have chosen the flag name as --middle-propagate-changes=VALUE to leave
the possibility open to later allow values like "nodes-only" or
something like that. But currently only "true" and "false" are
supported.

This replaces the hardcoded check for the gazeteer output in the middle.
As the (now deleted) comment in the code shows an earlier intention was
to let the output tell the middle whether it needs the propagation. But
this commit is not going that route: Some outputs can not know whether
the propagation is needed (i.e. the flex output) without having an extra
flag for that. But if we need a flag anyway, it makes more sense to have
it on the middle where it belongs thematically.

Fixes #1304
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/osm2pgsql/pull/1310

-- Commit Summary --

  * Add --middle-propagate-changes option

-- File Changes --

    M docs/osm2pgsql.md (8)
    M src/middle-pgsql.cpp (8)
    M src/options.cpp (18)
    M src/options.hpp (6)
    M src/osm2pgsql.cpp (10)
    M src/osmdata.cpp (11)
    M src/osmdata.hpp (1)
    M src/output-gazetteer.hpp (2)
    M src/output-null.hpp (2)
    M src/output.hpp (2)
    M tests/common-import.hpp (10)
    A tests/data/test_propagation.opl (13)
    A tests/data/test_propagation_diff.opl (2)
    M tests/regression.py (27)

-- Patch Links --

https://github.com/openstreetmap/osm2pgsql/pull/1310.patch
https://github.com/openstreetmap/osm2pgsql/pull/1310.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1310
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20201105/728c8341/attachment-0001.htm>


More information about the Tile-serving mailing list