[Tile-serving] [openstreetmap/osm2pgsql] Flex output does not by default generate "hstore" tags column in combination with "compatible.lua" (#1333)

[mboeringa]

Note: I build osm2pgsql from scratch yesterday (21st november), so should be on the latest master code with this.

Minor issue, but I noticed the **compatible.lua** script, that is part of the "flex-config" folder with example LUA scripts that can be used either "as-is" or as a basis for your own style development, does not set the **local hstore** variable to True. As a consequence, no **hstore** column is generated, even though the **local hstore_match_only** variable is set to True.

Since as I understand it, the compatible.lua scripts is meant as an easy way to generate a schema compatible with current pgsql output for users starting to familiarize themselves with the new flex output, that most likely means for a lot of people generating output based on openstreetmap-carto as input style. As a consequence, I think it would be good if the compatible.lua script by default set the **local hstore** variable to True.

Using the old pgsql output in combination with recent releases of openstreetmap-carto always seems to generate an hstore column, so from that perspective being "compatible" likely means an hstore column by default. I would thus suggest to change this in **compatible.lua**.

Note that I did check that changing the **local hstore** to True, does indeed succesfully generate the "tags" hstore column, so that part is OK.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/issues/1333
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20201122/f4f3f8a1/attachment.htm>