[Tile-serving] [openstreetmap/osm2pgsql] Extended schema support to middle and pgsql/multi output (#1288)

[Sarah Hoffmann]

@lonvia commented on this pull request.



> @@ -121,6 +124,10 @@ def setUpClass(cls):
 
     @classmethod
     def tearDownClass(cls):
+        with psycopg2.connect("dbname='{}'".format(CONFIG['test_database'])) as conn:
+            with conn.cursor() as cur:
+                if cls.schema:

You'd want to pull out this 'if' to avoid creating a connection when there is no schema.

>      extra_params = ['--slim', '-d', 'postgres:///' + CONFIG['test_database']]
 
+# Schema tests
+
+class TestDBOutputSchema(BaseUpdateRunnerWithOutputSchema, unittest.TestCase,
+                         PgsqlBaseTests):
+    extra_params = ['--slim', '--output-pgsql-schema=osm']

I would expect that the `PgsqlBaseTests` do not work here because the tests use table names without a schema. Am I missing something?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1288#pullrequestreview-507230743
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20201013/cdc110ee/attachment.htm>