[Tile-serving] [openstreetmap/osm2pgsql] Fix _LARGEFILE64_SOURCE redifinition (#1452)
Jochen Topf
notifications at github.com
Tue Apr 13 07:04:32 UTC 2021
It doesn't matter where this is defined, as long as it is defined. But I think there is a problem here which the PR doesn't solve. We should define this in the CMake config globally for the whole project. Otherwise me have different settings in different compilation units which might lead to problems.
But there is another problem. The mentioned man page says:
> New programs should not employ this macro; instead _FILE_OFFSET_BITS=64 should be employed.
So we should probably switch to that.
So I suggest we remove that `#define` here and add the newer one to the CMake config.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1452#issuecomment-818495266
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20210413/86f9d6e6/attachment.htm>
More information about the Tile-serving
mailing list