[Tile-serving] [openstreetmap/osm2pgsql] Refactoring of WKB code (#1469)

Jochen Topf notifications at github.com
Thu Apr 29 13:18:12 UTC 2021


These commits refactor some of the WKB code step by step to
* make it cleaner
* pull generation of points geometries out of the `ewkb::writer_t` class to make its use faster and simpler (we'll use this in the upcoming new pgsql middle)
* fix potential buffer overflow in `ewkb::parser_t`

This leaves the WKB code a bit cleaner, there is still the `get_area()` function etc. to clean up which doesn't really belong in the `parser_t` class and some of the code should probably be moved into a `.cpp` file, but I leave that for another day.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/osm2pgsql/pull/1469

-- Commit Summary --

  * Refactoring: Move code out of ewkb:writer_t class
  * Add stand-alone function for creating EWKB point geometry
  * Reorder contents of ewkb::writer_t class
  * Clean up ewkb::parser_t and check for buffer overflow

-- File Changes --

    M src/wkb.hpp (168)

-- Patch Links --

https://github.com/openstreetmap/osm2pgsql/pull/1469.patch
https://github.com/openstreetmap/osm2pgsql/pull/1469.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1469
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20210429/dabefc0b/attachment.htm>


More information about the Tile-serving mailing list