[Tile-serving] [openstreetmap/mod_tile] Convert -pthread to -Wc, -pthread when invoking apxs (#249)

David Hummel notifications at github.com
Sun Aug 1 18:35:47 UTC 2021


@hummeltech approved this pull request.

Thank you for the fix, it does indeed fix the issue I was having! Also, do you think `-Wc,pthread` should be added (by adding another line to the `apxs` calls) since it is missing from at least some other Linux distributions?
If so, I'm guessing something like this would do the trick:
```
		$(subst -pthread,-Wc$(COMMA)-pthread,$(PTHREAD_CFLAGS)) \
```

Here's a breakdown of the flags used on the other two Linux distributions I had worked on a build workflow for:
https://github.com/openstreetmap/mod_tile/pull/248#discussion_r680534646



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/mod_tile/pull/249#pullrequestreview-719687637
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20210801/4ec6d1a3/attachment.htm>


More information about the Tile-serving mailing list