[Tile-serving] [openstreetmap/osm2pgsql] Geom refactor (#1396)
Jochen Topf
notifications at github.com
Mon Jan 18 19:15:56 UTC 2021
This PR fixes #1394 and another bug. To better debug this and as part of the work we want to do anyway of refactoring the geometry code, I have already refactored some of the code and added tests. The refactored code is certainly not perfect and I expect more iterations until we see clearly how to best separate out the many functions.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/osm2pgsql/pull/1396
-- Commit Summary --
* Add some asserts
* Move low-level geom functions into their own file and test them
* Add linestring type
* Use using to make tests more readable
* Move linestring splitting into geom.cpp and fix it
* Move test buffer class into header so we can reuse it
* Add comparison function to linestring_t simplifying tests
* Move multiline generation into geom.cpp and fix bug
* Remove function that doesn't do much.
-- File Changes --
M src/CMakeLists.txt (1)
A src/geom.cpp (295)
A src/geom.hpp (178)
M src/osmium-builder.cpp (256)
M src/wkb.hpp (11)
M tests/CMakeLists.txt (1)
A tests/common-buffer.hpp (70)
A tests/test-geom.cpp (442)
M tests/test-middle.cpp (51)
-- Patch Links --
https://github.com/openstreetmap/osm2pgsql/pull/1396.patch
https://github.com/openstreetmap/osm2pgsql/pull/1396.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1396
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20210118/3aaf400a/attachment.htm>
More information about the Tile-serving
mailing list