[Tile-serving] [openstreetmap/mod_tile] Add a Prometheus metrics endpoint (#222)

[Tom Hughes]

So I don't see any problem with dropping the duplicate global statistics and you've correctly pluralised some names that I had wrong put in single form.

I not convinced about `modtile_cached_tiles_total` because the `cached` part doesn't seem to mean anything or even be correctly in all cases - those are counters of tiles served and whether they were rendered of served from cache so not all those values represent cached tiles. I would just go with pluralising it as `modtile_tiles_total` or maybe `modtile_tile_responses_total` s those are response counters.

I'm not sure that `buffer` in `modtile_buffer_reads_xxx` is useful either, or that it has any real meaning. I'm really sure what the buffer part in the internal name means - it is just counting the reads from the backing store and how long they take so what buffer is it referring to? Maybe `modtile_tile_reads_total` and `modtile_tile_reads_seconds`? Does `duration` add anything to the second one?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/mod_tile/pull/222#issuecomment-879287528
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20210713/6fc2cf42/attachment-0001.htm>