[Tile-serving] [openstreetmap/osm2pgsql] Improved geometry IsValid check (#1484)

[Sarah Hoffmann]

@lonvia commented on this pull request.

Should the trigger be dropped when --drop is given? That would correspond to the previous behaviour.

>              conn.get_count("pg_proc",
                            "proname = 'osm2pgsql_test_point_osm2pgsql_valid'"));
 
-    REQUIRE(1 == conn.get_count("pg_trigger"));
-    REQUIRE(1 ==
+    REQUIRE(0 == conn.get_count("pg_trigger"));
+    REQUIRE(0 ==

So you don't test at all anymore that the trigger ends up in the right schema?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1484#pullrequestreview-656356835
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20210511/d624c8a7/attachment.htm>