[Tile-serving] [openstreetmap/osm2pgsql] Pgsql cleanup again (PR #1856)

Jochen Topf notifications at github.com
Tue Dec 20 08:31:25 UTC 2022


It was always confusing to me that there were two functions `query()` and `exec()` to send SQL commands to the server and which one to use when. This PR cleans that up and leaves only `exec()`. Some other smaller cleanups along the way, see individual commits.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/osm2pgsql/pull/1856

-- Commit Summary --

  * Clean up pgsql code related to COPY command
  * Remove check for empty command from pg_conn_t::exec()
  * Remove pg_conn_t::query() function, use pg_conn_t::exec() instead

-- File Changes --

    M src/db-copy.cpp (6)
    M src/middle-pgsql.cpp (11)
    M src/pgsql-capabilities.cpp (16)
    M src/pgsql-helper.cpp (2)
    M src/pgsql.cpp (61)
    M src/pgsql.hpp (37)
    M tests/common-pg.hpp (6)
    M tests/test-db-copy-mgr.cpp (3)
    M tests/test-output-gazetteer.cpp (2)
    M tests/test-pgsql.cpp (4)

-- Patch Links --

https://github.com/openstreetmap/osm2pgsql/pull/1856.patch
https://github.com/openstreetmap/osm2pgsql/pull/1856.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1856
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/osm2pgsql/pull/1856 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20221220/820e2228/attachment-0001.htm>


More information about the Tile-serving mailing list