[Tile-serving] [openstreetmap/mod_tile] expire_tile buffer overrun? (Issue #276)

[nielsole]

C isn't exactly my back alley, but that is a buffer overrun isn't it?

https://github.com/openstreetmap/mod_tile/blob/9d34dd80444b204ef595e40e14ca4c64024d5dee/src/cache_expire.c#L117-L118

It is called here: https://github.com/openstreetmap/mod_tile/blob/master/src/metatile.cpp#L139
Which in turn is called here: https://github.com/openstreetmap/mod_tile/blob/f28cda992077c38684628cd764742223ab10a3ec/src/gen_tile.cpp#L505

https://github.com/openstreetmap/mod_tile/blob/f28cda992077c38684628cd764742223ab10a3ec/src/gen_tile.cpp#L106

is limited by `PATH_MAX` which is usually 4096 on Linux and can thereby be > 1024.

This is also not checked during parsing: https://github.com/openstreetmap/mod_tile/blob/9d34dd80444b204ef595e40e14ca4c64024d5dee/src/daemon.c#L862

Or am I overlooking something?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/mod_tile/issues/276
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/mod_tile/issues/276 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20220510/585f441b/attachment.htm>