[Tile-serving] [openstreetmap/mod_tile] Resolve various compiler warnings and errors (PR #279)

Hummeltech notifications at github.com
Sat May 21 17:52:20 UTC 2022


* Resolved `cppcheck`-detected `memleak` in `src/store_rados.c`
  * `store` was not being `free`d (see [here](https://github.com/hummeltech/mod_tile/blob/a14924a999d0c465a023c02301964c41700744f1/src/store_rados.c#L354-L356))
* Resolved all `discarded-qualifiers` warnings in `src/daemon.c`
  * Warnings can be seen [here](https://github.com/openstreetmap/mod_tile/runs/6538303841?check_suite_focus=true#step:9:327)
* Resolved `format=` warning in `src/mod_tile.c`
  * Warning can be seen [here](https://github.com/openstreetmap/mod_tile/runs/6538303841?check_suite_focus=true#step:9:930)
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/mod_tile/pull/279

-- Commit Summary --

  * Resolved warnings in `src/daemon.c`
  * Resolved warning in `src/mod_tile.c`
  * Resolved `cppcheck`-detected error

-- File Changes --

    M includes/daemon.h (14)
    M src/daemon.c (22)
    M src/mod_tile.c (2)
    M src/store_rados.c (2)

-- Patch Links --

https://github.com/openstreetmap/mod_tile/pull/279.patch
https://github.com/openstreetmap/mod_tile/pull/279.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/mod_tile/pull/279
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/mod_tile/pull/279 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20220521/32f5bb74/attachment.htm>


More information about the Tile-serving mailing list