[Tile-serving] [openstreetmap/osm2pgsql] Remove copy_thread parameter from output constructors (PR #1838)

Sarah Hoffmann notifications at github.com
Wed Nov 30 08:53:53 UTC 2022


@lonvia commented on this pull request.



> @@ -32,9 +32,9 @@ class output_gazetteer_t : public output_t
     /// Constructor for new objects
     output_gazetteer_t(std::shared_ptr<middle_query_t> const &mid,
                        std::shared_ptr<thread_pool_t> thread_pool,
-                       options_t const &options,
-                       std::shared_ptr<db_copy_thread_t> const &copy_thread)
-    : output_t(mid, std::move(thread_pool), options), m_copy(copy_thread),
+                       options_t const &options)
+    : output_t(mid, std::move(thread_pool), options),
+      m_copy(std::make_shared<db_copy_thread_t>(get_options()->conninfo)),

Just use `options.conninfo` here to be consistent with m_proj initialisation below?

Dito above in output-flex.cpp.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1838#pullrequestreview-1198915434
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/osm2pgsql/pull/1838/review/1198915434 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20221130/673a7eb9/attachment-0001.htm>


More information about the Tile-serving mailing list