[Tile-serving] [openstreetmap/mod_tile] Fixing a few minor source code issues (PR #307)

Hummeltech notifications at github.com
Wed Feb 22 15:47:36 UTC 2023


* From `CodeQL`:
  * `src/store_ro_http_proxy.c`
    * Wrong type of arguments to formatting function
* From `Flawfinder`:
  * `src/gen_tile_test.cpp`
    * Ignore alerts about `system` & `popen` as this is expected and used only for testing
    * Remove unused `char * buf_tmp` in two test sections
    * Use `sizeof` rather than `strlen`
    * Use `snprintf` rather than `sprintf`
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/mod_tile/pull/307

-- Commit Summary --

  * Fix 'Wrong type of arguments to formatting function' alerts
  * Fix numerous flawfinder issues in `src/gen_tile_test.cpp`

-- File Changes --

    M src/gen_tile_test.cpp (65)
    M src/store_ro_http_proxy.c (8)

-- Patch Links --

https://github.com/openstreetmap/mod_tile/pull/307.patch
https://github.com/openstreetmap/mod_tile/pull/307.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/mod_tile/pull/307
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/mod_tile/pull/307 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20230222/9a5bce8f/attachment.htm>


More information about the Tile-serving mailing list