[Tile-serving] [openstreetmap/osm2pgsql] Use fmt::format() function instead of ""_format literal (PR #1874)

[Jochen Topf]

This replaces most uses of the ""_format literal with function calls to fmt::format(). The latter form is available in all versions of the fmt library, while the ""_format literal is deprecated in version 8 and removed in version 9.

This might cost us some performance and early error detection, because in at least some versions of the fmt library the _format() construct was used to compile the format patterns at run time. That's why there are some uses of the literal left in places where performance might be more critical, they need a closer look.

See #1859
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/osm2pgsql/pull/1874

-- Commit Summary --

  * Use fmt::format() function instead of ""_format literal

-- File Changes --

    M src/flex-index.cpp (2)
    M src/flex-table-column.cpp (19)
    M src/flex-table.cpp (45)
    M src/flex-write.cpp (4)
    M src/node-persistent-cache.cpp (2)
    M src/output-flex.cpp (2)
    M src/output-gazetteer.cpp (21)
    M src/pgsql-capabilities.cpp (4)
    M src/pgsql-helper.cpp (6)
    M src/progress-display.cpp (4)
    M src/reprojection-generic-proj4.cpp (6)
    M src/reprojection-generic-proj6.cpp (6)
    M src/table.cpp (13)
    M src/taginfo.cpp (4)
    M src/util.cpp (8)
    M tests/common-buffer.hpp (4)
    M tests/common-pg.hpp (10)
    M tests/test-db-copy-mgr.cpp (2)
    M tests/test-middle.cpp (4)
    M tests/test-output-gazetteer.cpp (24)
    M tests/test-output-pgsql-z_order.cpp (9)

-- Patch Links --

https://github.com/openstreetmap/osm2pgsql/pull/1874.patch
https://github.com/openstreetmap/osm2pgsql/pull/1874.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1874
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/osm2pgsql/pull/1874 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20230105/b8e713a3/attachment.htm>