[Tile-serving] [openstreetmap/osm2pgsql] Various cleanups/fixes found by clang-tidy (PR #1961)

[Jochen Topf]

@pnorman I am not sure either. But the alternatives are to

a) disable the warning in general which can hide some problem
b) disable this warning specifically with a comment which is even worse
c) ignore the messages which means I'll have to check the results of th clang-tidy run every time and remember which warnings were important and which weren't

So I choose to "give in" in this case. More generally managment of the clang-tidy warnings (and similar for compiler warnings) is a careful management of selecting to act on the warning or do one of the above. There are some compromises necessary and different developers will probably make different choices on that. But overall having those checks has found so many bugs that it is absolutly useful to have them and in general act on them.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1961#issuecomment-1549032859
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/osm2pgsql/pull/1961/c1549032859 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20230515/d62d4c82/attachment.htm>