[Tile-serving] [osm2pgsql-dev/osm2pgsql] Use anonymous namespaces instead of declaring static functions (PR #2203)

[Jochen Topf]

This is recommended in C++ Core Guidelines SF.22
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rs-unnamed2

Sorry for the long PR. This basically sticks a `namespace { ... } // anonymous namespace` around all sections that had static functions and removes the `static` keyword. In some cases I moved some functions around to consolidate several anon namespace sections into one. This is not consistently done though, in some case I thought it to be better to leave the anon section in the context of the code around it.
You can view, comment on, or merge this pull request online at:

  https://github.com/osm2pgsql-dev/osm2pgsql/pull/2203

-- Commit Summary --

  * Use anonymous namespaces instead of declaring static functions

-- File Changes --

    M src/command-line-parser.cpp (53)
    M src/flex-lua-expire-output.cpp (6)
    M src/flex-lua-geom.cpp (36)
    M src/flex-lua-index.cpp (16)
    M src/flex-lua-table.cpp (40)
    M src/flex-table-column.cpp (8)
    M src/flex-table.cpp (8)
    M src/flex-write.cpp (41)
    M src/gen/gen-base.cpp (6)
    M src/gen/gen-rivers.cpp (39)
    M src/gen/gen-tile-builtup.cpp (88)
    M src/gen/gen-tile-raster.cpp (98)
    M src/gen/osm2pgsql-gen.cpp (33)
    M src/gen/tracer.cpp (22)
    M src/geom-from-osm.cpp (41)
    M src/geom-functions.cpp (55)
    M src/geom-pole-of-inaccessibility.cpp (24)
    M src/input.cpp (78)
    M src/lua-utils.cpp (6)
    M src/middle-pgsql.cpp (59)
    M src/middle-ram.cpp (78)
    M src/osm2pgsql.cpp (37)
    M src/output-flex.cpp (200)
    M src/output-pgsql.cpp (67)
    M src/pgsql-capabilities.cpp (23)
    M src/pgsql.cpp (31)
    M src/progress-display.cpp (8)
    M src/taginfo.cpp (6)
    M src/tagtransform-c.cpp (16)
    M src/tagtransform-lua.cpp (6)
    M src/tile.cpp (8)

-- Patch Links --

https://github.com/osm2pgsql-dev/osm2pgsql/pull/2203.patch
https://github.com/osm2pgsql-dev/osm2pgsql/pull/2203.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/osm2pgsql-dev/osm2pgsql/pull/2203
You are receiving this because you are subscribed to this thread.

Message ID: <osm2pgsql-dev/osm2pgsql/pull/2203 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20240616/91b30f61/attachment.htm>