[Tile-serving] [osm2pgsql-dev/osm2pgsql] Remove special case for old PostGIS versions when clustering (PR #2188)

Paul Norman notifications at github.com
Tue May 28 06:38:57 UTC 2024


@pnorman requested changes on this pull request.

I'm okay with bumping our requirements to >= 3 but I don't think we should enforce that, since there's nothing stopping it from running on 2.4

> @@ -81,6 +81,10 @@ static void check_db(options_t const &options)
 
     init_database_capabilities(db_connection);
 
+    if (get_postgis_version().major < 3) {
+        throw std::runtime_error{"Need at least PostGIS version 3"};
+    }

We don't need to check for PostGIS >= 3 as the SQL statement we've got will work on older versions. The order the old versions produce is not as good as GeoHash but it still works.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/osm2pgsql-dev/osm2pgsql/pull/2188#pullrequestreview-2081870539
You are receiving this because you are subscribed to this thread.

Message ID: <osm2pgsql-dev/osm2pgsql/pull/2188/review/2081870539 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20240527/56b58666/attachment.htm>


More information about the Tile-serving mailing list