[Tile-serving] [osm2pgsql-dev/osm2pgsql] Remove special case for old PostGIS versions when clustering (PR #2188)

[Sarah Hoffmann]

@lonvia commented on this pull request.



> @@ -67,8 +67,8 @@ with other versions of those libraries (set the `EXTERNAL_*libname*` option to
 * [protozero](https://github.com/mapbox/protozero) (>= 1.6.3)
 
 It also requires access to a database server running
-[PostgreSQL](https://www.postgresql.org/) 9.6+ and

This is, what we test, so I'd leave it in. May be do something like (9.6+ works, 13+ strongly recommended)?

> @@ -81,6 +81,10 @@ static void check_db(options_t const &options)
 
     init_database_capabilities(db_connection);
 
+    if (get_postgis_version().major < 3) {
+        throw std::runtime_error{"Need at least PostGIS version 3"};
+    }

Shouldn't that be `pv.minor < 5`?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/osm2pgsql-dev/osm2pgsql/pull/2188#pullrequestreview-2091144814
You are receiving this because you are subscribed to this thread.

Message ID: <osm2pgsql-dev/osm2pgsql/pull/2188/review/2091144814 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20240531/08ee2f31/attachment.htm>