[Tile-serving] [osm2pgsql-dev/osm2pgsql] Make property handling more robust (PR #2244)

Jochen Topf notifications at github.com
Sun Sep 15 14:29:38 UTC 2024


(Changes to) Properties are stored at a later time in the database so the db is not changed if osm2pgsql fails for some reason. Basically we are trying to do as many checks as possible before actually writing the properties to the db. For instance the input file is now actually opened before properties are written,

This solves some cases already mentioned in PR #2085. 
You can view, comment on, or merge this pull request online at:

  https://github.com/osm2pgsql-dev/osm2pgsql/pull/2244

-- Commit Summary --

  * Simplify property handling and do updates all at once
  * Check that properties can be loaded in osmp2glsq-gen
  * Store properties in database only later after more checks

-- File Changes --

    M src/gen/osm2pgsql-gen.cpp (6)
    M src/osm2pgsql.cpp (33)
    M src/properties.cpp (69)
    M src/properties.hpp (29)
    M tests/test-properties.cpp (19)

-- Patch Links --

https://github.com/osm2pgsql-dev/osm2pgsql/pull/2244.patch
https://github.com/osm2pgsql-dev/osm2pgsql/pull/2244.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/osm2pgsql-dev/osm2pgsql/pull/2244
You are receiving this because you are subscribed to this thread.

Message ID: <osm2pgsql-dev/osm2pgsql/pull/2244 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20240915/b5be36b4/attachment.htm>


More information about the Tile-serving mailing list