[Tile-serving] [osm2pgsql-dev/osm2pgsql] Allow table inserts without context object (PR #2491)

Sarah Hoffmann notifications at github.com
Thu Jul 2 07:32:03 UTC 2026


@lonvia commented on this pull request.



>              } else if (column.type() == table_column_type::id_num) {
+                if (id == 0) {

Isn't it safer to check for `objtype == osmium::item_type::undefined` here as well? Just in case somebody works with zero IDs? (Or, in fact, just check for `(!object)`.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/osm2pgsql-dev/osm2pgsql/pull/2491#pullrequestreview-4615335566
You are receiving this because you are subscribed to this thread.

Message ID: <osm2pgsql-dev/osm2pgsql/pull/2491/review/4615335566 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20260702/c6e376f7/attachment.htm>


More information about the Tile-serving mailing list