[Tilesathome] Render request issue?

[Robert (Jamie) Munro]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthias Julius wrote:
> Dirk-Lüder Kreie <osm-list at deelkar.net> writes:
> 
>> For example the no data error (which was the cause in this case) should
>> have such consequences because it can have only the following reasons:
>> * the API appears down (due to the user being blocked or db overload or
>>   actual downtime) or
>> * the client uses the wrong URL to fetch data.
> 
> Actually, this time around the automatic client restarting after the
> update appearently failed.  When the render queue was turned
> back on the client tried to download data from the 0.4 API which of
> course failed.  Unfortunately, the mechanism to put the job back into
> the queue also did not seem to engage.
> 
> Therefore, my client did grab every job it could get, got no data and
> went to the next job.  Restarting the client solved the issue.

It looks like you are not the only client doing this, based on the
graphs at http://tah.openstreetmap.org/Log/Requests/

The active queues are still filling as soon as jobs are recycled.

Can we add a field to the tile_queue table called "client_ip", then log
the address of the client who took the request? Then we can easily find
out who is responsible, and we can block them.

Robert (Jamie) Munro


P.s. this patch might do the trick, but I haven't tested it.

Index: requests.inc
===================================================================
- --- requests.inc        (revision 4940)
+++ requests.inc        (working copy)
@@ -44,8 +44,9 @@
   if($FromMode != NULL) {
     # Move the specified request to the new mode
     $SQL = sprintf(
- -      "update `tiles_queue` set `status`=%d, `date`=now() where `x`=%d
and `y`=%d and `z`=%d and `status`=%d;",
+      "update `tiles_queue` set `status`=%d, `date`=now(),
`client_ip`='%s' where `x`=%d and `y`=%d and `z`=%d and `status`=%d;",
       $ToMode,
+      $_SERVER['REMOTE_ADDR'],
       $X,
       $Y,
       $Z,
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHDmLez+aYVHdncI0RAmU6AJ4oxwyzqP1JfYKUe7o8wJqFYA4lUwCg6Bu6
q8mePZ6d0WORfYewP/+8knM=
=XkcX
-----END PGP SIGNATURE-----