[Tilesathome] Request (err, suggestion) for more t at h client simplification
spaetz
osm at sspaeth.de
Thu Aug 7 11:51:31 BST 2008
As the new tileserver expects each upload to be exactly one tileset (and i don't plan to change that in the near future as it makes processing on the server a heck more complicated), I would suggest that the t at h client can be much simplified by removing unneeded options. I had a look around the code, but I find it pretty obfuscated how and where the zipping and uploading happens. Or have you a clue how this function works, for example? :
....
sub compressAndUpload
{
my $error=0;
$error=compress(1) + 2 * upload(1) + 4 * compress(2) + 8 * upload(2);
return $error;
}
....
Anyway, here are my suggestions:
1) remove the options UploadChunkSize and UploadChunkCount, we don't split tilesets, there are no serverside restrictions on upload sizes. This is in compress.pl (and the various config options)
2) remove the option to "gather single tiles in a directory" and upload that hotchpotch in one go. The server currently can't use those single tiles at all. This would get rid of many things in various files. AFAIK "processTileBatch" in compress.pl and other stuf could completely go away and make the client easier to understand.
Of course, if you thing we'll need this again, it could make sense to keep it in. Otherwise, I am for simpler-is-better. I don't want to make these decisions and rip out the code (I'd break stuff, as I don't understand Perl that well), but this is what would make sense from a server perspective.
spaetz
More information about the Tilesathome
mailing list