[Tilesathome] Suggestions for removing t at h client options

[Matthias Julius]

spaetz <osm at sspaeth.de> writes:

> Hi, I will do (some of the) following suggestions if nobody speaks up
> against it:
>
> There is a plethory of command line options for tilesGen, not all of
> which ii find useful. It's a quite a bit of duplicatedcode paths, so
> it's hard to add something without forgetting those other ones.
>
> 1) Remove "tilesGen.pl update". The update check is run anyway for all
> modes basically, so no need for a separate option.

and "svn up" just does the same.

>
> 2) There are tons of upload options: "upload", "upload_conditional",
> and "upload_loop". I can see why upload and upload_loop could be
> required (although it would remove a duplicate code path if we made
> loop' just an option to "upload", ie. "./tilesGen.pl upload
> [-loop]"). But is there anyone using upload_conditional? It's supposed
> to upload only if there are enough files, but we don't use that at
> all. Also, the regular "upload" should be uploading stuff if it makes
> sense and not otherwise, so I don't think this makes any sense. I
> would like to remove "upload_conditional" if nobody complains.

We can keep the modes (upload and upload_loop) and still consolidate
the code.  This is on my ToDo list as well.

>
> 3) If no option is given at all, it fetches one request from the
> server, renders it and exits without uploading. Is this something
> people are actually using? If yes, should we combine this with the
> "loop" mode and make "-loop" and option, just like it could be used
> for the upload thing?

I wouldn't change standard behavior without broad consensus.  And I
don't think it is necessary to change the user interface (apart from
removing obsolete options) in order to simplify the code.

Matthias