[Tilesathome] deleting temp folder (was Problem under windows again)

[Matthias Julius]

spaetz <osm at sspaeth.de> writes:

>> Deelkar wrote:
> Matthias Julius wrote:
>
>> > And I do agree, the directory usage structure needs an overhaul.
>
> Agreed, I was also very close to tackling this :-). I had started by
> reducing some of the unneeded temporary files. I propose to create a
> temporary dir in WorkingDir and use that for all files temporary. The
> tmpdir could be set as attribute to the Request object (that would
> fit, wouldn't it?) and would thus be passed around. A s
> suggested earlier, that directory is just deleted after successful
> rendering (or kept around in Debug mode).

I wanted to call it Z_X_Y to make it easy for somebody trying to debug
things to find the data.

> What exactly is it that perl::Error gives us? One thing that strikes
> me as insufficient currently, is that a CTRL-C in inskscape (or or/p)
> will hand back jobs as "BadSVG" or "RenderFailure", which is very
> misleading. But I think we are able to capture those exceptions with
> perl standard means, perhaps others no more about that. It would be
> great if we could hand back a job as "UserAborted" rather than
> misleading error messages.

It implements proper exception handling which allows to catch
exceptions where you want to deal with them without having to pass
error return values up the sub routine stack.  For example, if
anything goes wrong with the rendering of a tileset there would be an
exception thrown wherever it happened and it would be caught in the
top level routine which then can decide whether to try it again,
return the request to the server or give up alltogether.  No need to
check every function call for an error value.

And since there were other voices in favor of the Error module I won't
hesitate using it myself.

>
> All in all, I am very happy with the direction the code evolved during
> the last weeks, even if it implied an occational unfortunate breakdown
> for renderers while we had things botched up. I blame it on the OSM
> Foundation's QA department :-).

Yeah, and I had my share on those hickups.  It's good that there are
paople around who can fix things if necessary.

It is actually a bit scary to type 'svn ci' if you know that a few
minutes later the whole rendering machinery might grind to a halt if
you missed a semicolon or so.

>
> spaetz
>
> P.S. Matthias, you created lib::tahconfig.pm, and there is also
> tahconfig.pm. Do you plan merging these somehow? Or some of it?

I thought about it.  I'll put it on my ToDo.

Matthias