[Tilesathome] Problem under windows again

[spaetz]

On Mon, Aug 25, 2008 at 02:41:24PM +0200, spaetz wrote:
> > 2) @Spaetz:
> >     Another, maybe dangerous thing is that uploaded
> >     ZIPs are not renamed to ...zip.uploaded (as I remember correctly)
> >     anymore. This means, if I use DeleteZipFilesAfterUpload=0
> >     in my config they will be uploaded again and again.
> 
> That would indeed be bad. I suggest not using Delete...=0 for now. I am rewrking the whole temporary file stuff at the moment anyway.

I have just tried it out: 

after uploading I have:

ls tmp/uploadable/            
_1054_18851_0_captionless_tileset.zip_uploaded  _1054_18851_2_maplint_tileset.zip_uploaded
_1054_18851_1_tile_tileset.zip_uploaded

And Upload.pm contains:

    # if we didn't encounter any errors error we get here
    if($Config->get("DeleteZipFilesAfterUpload"))
    {
        unlink($File);
    }
    else
    {
        move($File, $File."_uploaded");
    }


So this might be another Windows only thing, that someone should investigate on those boxes. To the best of my knowledge *nothing* has changed this code in a while though, so if it is broken now, I think it must have been broken before...

Nothing I can do there.

spaetz