[Tilesathome] Client 10225 not uploading everything

[spaetz]

On Wed, Aug 27, 2008 at 07:39:20PM +0200, Maarten Deen wrote:
> It seems that the latest stable client does render everything (provided you have 
> your decimal separator set to "."), but uploading is a problem here.

OK, there are 2 separate issues here. One has been reported by Dirk Moeller (name correct?) already: the deleting/moving of the tileset directories and the .zip dirs fails on windows while they are held open.

I have fixed this issue in the _unstable branch in revision  10240 by creating specific temporary .lock files that are held open instead of the .dir and .zip files. As this patch is pretty easy and fixes a serious bug I am going to merge it into stable once I have tested  it a bit.

> I have all tiles (directory tile_12_2653_1259.dir has files tile_12_*, 
> tile_13_*, tile_14_*, tile_15_*, tile_16_*, tile_17_*), but the zipfile that is 
> sent to the server only contains tile_12_2653_1259.png.

> 7-Zip (A)  4.58 beta  Copyright (c) 1999-2008 Igor Pavlov  2008-05-05
> Scanning
> 
> Creating archive C:\temp\TaH\uploadable\_58045_25244_tile_tileset.zip
> 
> Compressing  tile_12_2653_1259.png

This could be a 7zip problem, it certainly works with zip under Linux. Can you print out the command line that is called for the 7zip call and see if it makes sense? We just need to call the correct command that makes 7zip compress everything. Nothing significant has changed here, so I can't say what it is. I'll have a look at the older code though.

spaetz