[Tilesathome] Some bugs on Windows still there (maybe found the error!)

[Carsten Möller]

spaetz schrieb:
> On Wed, Aug 27, 2008 at 08:06:43PM +0200, Carsten M?ller wrote:
>>> On Wed, Aug 27, 2008 at 06:43:48PM +0200, Carsten M?ller wrote:
>>>> * in line 102 you open the zipfile (I assume for flock)
>>>> * in line 115 you call upload
>>>> * in line 285 upload tries to move or delete the zip
>>>> * in line 155 you close the zipfile
>>>>
>>>> This means, the opening of a file gets a lock
>>>> under windows! Is this an open for writing?
>>>> Then it should be clear why this happens!
>>> Good find. Locks in Windows are mandatory, meaning they can probably not be removed. On Linux they are just advisory locks, so the file can be moved anyway!
> 
>> Everything is Ok
>> cannot remove directory for 
>> C:\OSM\tilesAtLocal\temp\tile_12_2107_1180.dir: Permission denied at Com
>> press.pm line 119
>> [#0   0% compress] done
> 
> Yes, it is the very same reason. I have fixed the code in question in the _unstable branch. If you feel adventurous you can try it out and see if it works now. heck, we could enable flock for windows again in the current implementation, I believe :-)
> 
> 

I thought the same when I saw the open close logic around flock ;-)