[Tilesathome] Bug in code for batik=2

Henry Loenwind henry at loenwind.info
Mon May 5 04:00:08 BST 2008


Hi to whoever has svn access,

--- tilesGen.pl.old     2008-05-03 19:53:15.937500000 +0200
+++ tilesGen.pl 2008-05-05 04:51:02.453125000 +0200
@@ -1337,7 +1337,7 @@
          $Left,$Top,$Width,$Height,
          $TempFile,
          $Config{WorkingDirectory},
-        "output-$PID-z$Zoom.svg",
+        "output-$parent_pid-z$Zoom.svg",
          $stdOut);
      }
      else


or an even better way to fix this would be to clean up a little bit:

--- tilesGen.pl.old     2008-05-05 04:55:21.593750000 +0200
+++ tilesGen.pl 2008-05-05 04:56:34.984375000 +0200
@@ -1311,6 +1311,8 @@
      my $Width = $X2 - $X1;
      my $Height = $Y2 - $Y1;

+    my $svgFile = "output-$parent_pid-z$Zoom.svg";
+
      if ($Config{Batik} == "1") # batik as jar
      {
          $Cmd = sprintf("%s%s java -Xms256M -Xmx%s -jar %s -w %d -h %d 
-a %f,%f,%f,%f -m image/png -d \"%s\" \"%s%s\" > %s",
@@ -1323,7 +1325,7 @@
          $Left,$Top,$Width,$Height,
          $TempFile,
          $Config{WorkingDirectory},
-        "output-$parent_pid-z$Zoom.svg",
+        $svgFile,
          $stdOut);
      }
      elsif ($Config{Batik} == "2") # batik as executable (wrapper of 
some sort, i.e. on gentoo)
@@ -1337,7 +1339,7 @@
          $Left,$Top,$Width,$Height,
          $TempFile,
          $Config{WorkingDirectory},
-        "output-$PID-z$Zoom.svg",
+        $svgFile,
          $stdOut);
      }
      else
@@ -1351,7 +1353,7 @@
          $X1,$Y1,$X2,$Y2,
          $TempFile,
          $Config{WorkingDirectory},
-        "output-$parent_pid-z$Zoom.svg",
+        $svgFile,
          $stdOut);
      }

cu
Henry
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch1.diff
URL: <http://lists.openstreetmap.org/pipermail/tilesathome/attachments/20080505/cfe4892a/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch2.diff
URL: <http://lists.openstreetmap.org/pipermail/tilesathome/attachments/20080505/cfe4892a/attachment-0001.ksh>


More information about the Tilesathome mailing list