[Tilesathome] Another bug, another patch

Henry Loenwind henry at loenwind.info
Thu May 8 12:34:40 BST 2008


Hi,

actuually 2 bugs, but they are in the same lines, so just one patch.

Problem 1: "$Bin/upload.pl" is handed to the shell unquoted. However, 
$bin may contain spaces, so that fails. (BTW: why are the calls to 
upload and compress the only ones that use $bin?)

Problem 2: When spawning another Perl, the command used is just "perl". 
However, that may be a completely different Perl installation than the 
one used to run tilesGen.pl in the first place. (You'll have that often 
on systems that already include a (outdated) Perl, so users install a 
second one but don't want to replace the system Perl.) Correct way to do 
this is to use the special variable "$^X", which contains the patch to 
the current Perl executable.

If someone could check that in, please?

cu
Henry

PS: I started working on a re-architectured version of the tiles at home 
client. Basically the idea is to decouple the different tasks with some 
multi-process-safe inter-process communications. That will solve a 
couple of problems: (1) any number of instances will be able to run at 
the same time without conflicts, that will also (2) allow better load 
utilization over time (atm many cpu cycles go to waste because the 
client is doing some stuff), and it will also allow to utilize e.g. the 
capability of batik to process many files in one run.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch4.diff
URL: <http://lists.openstreetmap.org/pipermail/tilesathome/attachments/20080508/653684ee/attachment.ksh>


More information about the Tilesathome mailing list