[Tilesathome] patch: maplint not-in-map_features.pl
Knut Arne Bjørndal
bob+osm at cakebox.net
Mon Nov 10 19:24:53 GMT 2008
On Mon, Nov 10, 2008 at 07:18:19PM +0100, boris wrote:
> Hi,
>
> here a simple one line patch to fix a bug in not-in-map_features.pl
> it solves the problem when processing a tag like: value=horrible
I've actually rewritten the entire thing recently, just hadn't gotten
around to committing the script yet. As you can see I managed to get
the regex right the second time around:
http://trac.openstreetmap.org/browser/applications/lib/Geo-OSM-MapFeatures/lib/Geo/OSM/MapFeatures/Feature.pm#L60 ;)
Thanks for prodding me into commiting the test script as well.
> btw can someone also update the (current in use) not-in-map_features.xml file.
Done at the same time (r11883).
There are a couple of other fixes as well, such as understanding that
"..." means User Defined.
I'm not aware of any regressions, other than the fact that some value
tests are duplicated. It's functionally the same, just littering the
output a little bit and I don't intend to spend time doing anything
about it.
Ed: The hack that made it understand speeds with units went away since
I didn't want to clutter up the module with something that was, after
all, only a test. Hope you can make a good official unit system for
map features soon, the module should make it easier to add things like
it.
--
Knut Arne Bjørndal
aka Bob Kåre
bob+osm at cakebox.net
bobkare at irc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 4167 bytes
Desc: not available
URL: <http://lists.openstreetmap.org/pipermail/tilesathome/attachments/20081110/1150765f/attachment.bin>
More information about the Tilesathome
mailing list