[Tilesathome] patch for place_of_worship-icons

Raphael Studer studerap at gmail.com
Tue Nov 11 11:15:39 GMT 2008


> I think you made a change here (got no SVN here at my workplace):
>
> <rule e="way" k="amenity|shop"
> v="school|college|university|restaurant|shelter|supermarket|library|doctors|pharmacy|place_of_worship|parking|post_office|hospital|hotel|hostel|camp_site|bank|bus_station"
> layer="5">
>                        <areaText k="name" class="caption-casing generic-caption-casing"
> dy='-2.5px' text-anchor='middle' startOffset='50%' layer="5"/>
>                        <areaText k="name" class="caption-core generic-caption-core"
> dy='-2.5px' text-anchor='middle' startOffset='50%' layer="5"/>
>                </rule>
>
>
> This part of the code (followed) seems hard to extend and seems to
> exagerate the importance of sport, as it puts the building-tag nested
> inside a sport-rule.
>
> I think if we would keep things simple where it could be, that would
> help for the extension of the rules with other tags.
>
>                <rule e="way" k="sport" v="~" layer="5"> <!-- don't render captions
> for buildings, if sport is also set, thus honor offsets -->
>                        <rule e="way" k="building" v="*" layer="5">
>                                <!-- same goes if one of the following is set -->
>                                <rule e="way" k="amenity|shop"
> v="school|college|university|parking|supermarket" layer="5">
>                                </rule>
>                                <else>
>                                        <areaText k="name" class="caption-casing generic-caption-casing"
> text-anchor='middle' startOffset='50%' layer="5"/>
>                                        <areaText k="name" class="caption-core generic-caption-core"
> text-anchor='middle' startOffset='50%' layer="5"/>
>                                </else>
>                        </rule>
>                </rule>
>
> I'm not sure about this, maybe I'm wrong an the rules are fine as they
> are (and are also easily extensible). What do you think?

I think you're right..

These rules looks a little bit strange..

They don't want to have an offset if its a sport tag with a building
tag without a amenity|shop ...

Why should sport buildings not have an offset?

Regards,
Raphael




More information about the Tilesathome mailing list