[Tilesathome] Java search path

Stephan osm at stephans-server.de
Sat Feb 21 14:00:55 GMT 2009


Knut Arne Bjørndal wrote:
> I saw your commit, which I reverted because you had changed the line
> endings of the entire file to DOS style. Please use svn diff before
> committing to make sure you don't commit more than intended.
I did a diff before. Showed no differences other than the changed lines. 
Maybe SmartSVN ignores line-endings when doing a diff. Sorry about the 
trouble.

Shouldn't SVN automatically convert line-endings? I thought CVS was able 
to do this.
I suggest setting the property to let SVN do the EOL conversion.

> You also didn't use File::Spec, which means the paths won't be
> portable to Windows, I committed a better version just now.
I'm using windows. It was fine here. JAVA_HOME is set on the target 
system with the right path separators. I don't see a portability issue 
here. Windows (XP/Vista/Win7) has no problem with the forward slash.

> Also I see you added $Bin/../ to the batik search path, why do you
> want it to look one directory up from where the client lives? Or is
> there something in the windows client wrappers that make it chdir to a
> subdir before running tilesgen?

In case tah is installed to c:\tilesathome the dir inside the scripts is 
"c:\tilesathome\tilesathome". Supposed batik is installed in parallel to 
inkscape and the other tools the search path needs to be one level up.

Stephan





More information about the Tilesathome mailing list