[OSM-dev] PBF parsing frontend for osm2pgsql, tester wanted

Hartmut Holzgraefe hartmut at php.net
Tue Nov 2 23:00:34 GMT 2010

On 11/02/2010 10:07 PM, Jon Burgess wrote:
> When do you think the code will be ready to merge?

> There are a couple of other things I'd like to fix up and it may make
> more sense to do that directly in SVN instead of bouncing patches via
> the mailing list.
> - Make the code automatically switch to .pbf mode if the filename has
> that extension.

> - Add PTHREAD to the configure scripts, several bits of the code already
> look for HAVE_PTHREAD and will use multiple threads in a few places

fixed in the bzr tree

> - Move inputUTF8() to parse-xml2.c

why not keep that in its own file?

> - There are memory leaks in a couple of places

> - I think there are some problems with the PBF tag handling, it seems to
> call resetList(&(osmdata->tags)) in the wrong place in a few cases.

indeed ... moved it up to the beginning of the iteration loops now

> It
> should be looking at osmdata->extra_attributes to determine whether to
> append the uid/version/timestamp tags from the node&  way info.

right ... and fixed

> The pthread change is the only real regression in the code, the Makefile
> used to set it unconditionally. All the other issues are specific to the
> PBF mode which people should probably expect to have a few minor issues.
> I don't see this should be a blocker on merging the changes.

let me sleep over it ...


More information about the dev mailing list